-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give a kind to all node[] fields and better types in Java-generated code #2497
Conversation
eregon
commented
Feb 25, 2024
•
edited
Loading
edited
- Fixes Adding kind for node[] fields where possible #2058
I was wondering if CI would catch that InterpolatedStringNode#parts could be not only:
But also EmbeddedVariableNode (which I figured out by checking prism.c). |
Is there maybe a way to do runtime type checks using Sorbet? |
23abcdd
to
e8b73b5
Compare
I added my own runtime checks in nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! One small suggestion that I think will make this is a little easier to test. Also please rebase off #2517 after it's merged.
…n "any Node" * Fixes ruby#2058
* To avoid duplication.
e8b73b5
to
f731edc
Compare